bobbai00 commented on PR #5160: URL: https://github.com/apache/texera/pull/5160#issuecomment-4583606585
Thanks — that surfaced the real root cause. Regions are recreated on every `RegionUpdateEvent` during execution, so a toggle that only flipped the existing elements was lost the moment the next update arrived: regions went hidden mid-run even with the toggle on, and only "stuck" once updates stopped (i.e. after execution, or when not running). The earlier #4112-style fix had the same gap. Reworked it to be systematic: the Regions toggle is now a persistent flag on `JointGraphWrapper`. The editor reapplies it to the shared JointJS model both when the flag changes **and** every time regions are recreated, so the state can't be lost between updates. Since the model is shared, this covers the main canvas (#5120) and the mini-map (#4027) together, on and off during execution. The menu just sets the flag; the editor owns applying it. Verified locally: enable Regions → run → hulls stay visible on both surfaces for the whole execution; disable → hidden on both. Added tests for creation-while-enabled, recreation on a later update, and toggling existing regions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
