bobbai00 commented on PR #5160: URL: https://github.com/apache/texera/pull/5160#issuecomment-4583572603
Thanks for the pointer to #4112 — you were right. My `body/visibility` flip only ran on checkbox click, but #4495 made region elements default to *visible* and they're recreated on every execution update, so the mini-map kept showing fresh hulls regardless of the toggle. I've reverted regions to the proven approach from #4112: - The region element defaults to `visibility: "hidden"`, so newly-created regions start hidden on both surfaces. - `toggleRegion()` flips `body/visibility` on the shared JointJS model, which both the main canvas and the mini-map render — no per-paper CSS class involved. - Removed the `hide-region` class and its SCSS rule entirely. This fixes #5120 (main canvas) and keeps #4027 (mini-map) fixed in one mechanism. Verified locally that the hulls now appear/disappear together on both surfaces. Tests updated to cover the model-attribute toggle and that regions are created hidden. Ready for another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
