juliethecao commented on code in PR #5359:
URL: https://github.com/apache/texera/pull/5359#discussion_r3354246838
##########
.github/workflows/comment-commands.yml:
##########
@@ -153,8 +252,18 @@ jobs:
reviewers.push(h);
}
if (!reviewers.length && !team_reviewers.length) {
- core.warning(`No valid @mentions in '${action}'; skipping.`);
- return;
+ if (action !== 'request-review') {
+ core.warning(`No valid @mentions in '${action}'; skipping.`);
+ return;
+ }
+
+ reviewers.push(...await getReviewersFromBlame());
Review Comment:
- Added a repos.checkCollaborator call for each candidate login before
adding them to reviewerCounts.
- If the login is not a collaborator, it is skipped with a warning and never
enters the count, so only validated collaborators are passed to
requestReviewers.
- This prevents the atomic requestReviewers call from failing with a 422 due
to a single non-collaborator login (which would otherwise cause zero reviewers
to be added).
- The validation happens during the per-file blame loop, so
non-collaborators are filtered out before the frequency ranking and
MAX_REVIEWERS cap are applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
