Yicong-Huang commented on PR #5359: URL: https://github.com/apache/texera/pull/5359#issuecomment-4635229167
I do have one concern which is this `request-review` will automatically send out the review request to a real user, without confirming with PR author, and this may bother ppl and we don't have ways to precent it. For instance, suppose a contributor Alice committed to a file 5 years ago and no longer wish to work on texera. whenever someone uses this feature on a PR touched the file, Alice will get a request. She may not want to receive such a request. So I think there are two ways to go: 1. We could add a confirming phase, after CI kicks in, it will reply as a github comment about "Suggested reviewers: A, B, C". Then author use the command again explicitly `/request-review A B C` to actually send out the review request. This way, the author is in control of sending such a request. This can make the problem smaller, but from time to time, new contributors would still blindly send the request to Alice anyway if she is suggested by the CI. 2. We should make only committers to be the request target. This implicitly means we have higher requirement on committer: committers are expected to receive review requests, even if they don't wish to receive. This also reminds me of github limitation (to be verified though): I think github only allows the request target to be committers + anyone reviewed this PR before. So even if your suggestion contains A, B and C three contributors, only the committers (say B) in the suggestion list will receive the request (this may already satisfy the 2nd way above). But I feel it will still be benefitial to let author know A and C also have context. Based on all those thinking, here is a proposal, up for discussion: 1. Maybe we can run a CI when PR gets opened or updated, which sends a comment of "suggested reviewer: A, B (committer), C. You can use /request-review <committer> or @ others to ping them for review". 2. The author still needs to explicitly use `/request-review B` to request a committer for review. 3. The author can optionally add a comment `cc @A, @C, you may want to have a pass" to notify non-committers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
