kunwp1 commented on code in PR #5280:
URL: https://github.com/apache/texera/pull/5280#discussion_r3366015582
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/user/workflow/WorkflowResource.scala:
##########
@@ -611,7 +611,8 @@ class WorkflowResource extends LazyLogging {
.asScala
.toList
- LargeBinaryManager.deleteAllObjects()
+ // Delete large binaries for each execution belonging to the workflows
being removed
+ eids.foreach(eid =>
LargeBinaryManager.deleteByExecution(eid.longValue()))
Review Comment:
Agree. I moved the location similar to how other iceberg tables are cleaned
up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
