kunwp1 commented on code in PR #5280:
URL: https://github.com/apache/texera/pull/5280#discussion_r3366024846
##########
amber/src/test/python/pytexera/storage/test_large_binary_manager.py:
##########
@@ -152,3 +162,35 @@ def test_create_uses_default_bucket(self):
uri = large_binary_manager.create()
assert large_binary_manager.DEFAULT_BUCKET in uri
+ assert
f"objects/{large_binary_manager.get_current_execution_id()}/" in uri
+
+
+def test_create_stamps_execution_id(monkeypatch):
+ # Avoid touching real S3 while testing key generation.
+ monkeypatch.setattr(
+ large_binary_manager, "_ensure_bucket_exists", lambda bucket: None
+ )
+ monkeypatch.setattr(large_binary_manager, "_current_execution_id", 42)
Review Comment:
This comment is outdated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
