Ma77Ball opened a new pull request, #5545:
URL: https://github.com/apache/texera/pull/5545

   ### What changes were proposed in this PR?
   
   The default data-transfer batch size was controlled by **two** separate 
config keys, each with its own env var, both defaulting to `400`:
   
   - `network-buffering.default-data-transfer-batch-size` 
(`NETWORK_BUFFERING_DEFAULT_DATA_TRANSFER_BATCH_SIZE`), read by the backend 
(`ApplicationConfig.defaultDataTransferBatchSize`).
   - `gui.workflow-workspace.default-data-transfer-batch-size` 
(`GUI_WORKFLOW_WORKSPACE_DEFAULT_DATA_TRANSFER_BATCH_SIZE`), read by 
`GuiConfig` and sent to the frontend via `ConfigResource`.
   
   Having two keys for one value meant an operator could set one env var and 
forget the other, leaving the backend and GUI out of sync.
   
   This PR makes the `network-buffering` key the single source of truth:
   
   - `ConfigResource` now surfaces 
`ApplicationConfig.defaultDataTransferBatchSize` directly.
   - Removed the duplicate `guiWorkflowWorkspaceDefaultDataTransferBatchSize` 
field from `GuiConfig`.
   - Removed the duplicate key (and its env override) from `gui.conf`.
   
   The frontend is unchanged: the JSON field name 
(`defaultDataTransferBatchSize`) it consumes stays the same.
   
   ### Any related issues, documentation, discussions?
   
   Closes #5544
   
   ### How was this PR tested?
   
   - `sbt Config/compile ConfigService/compile` both succeed.
   - Repo-wide grep confirms no remaining references to the old key or 
`GUI_WORKFLOW_WORKSPACE_DEFAULT_DATA_TRANSFER_BATCH_SIZE` (outside generated 
`dist/` artifacts).
   - The backend reader of the canonical key is untouched, so existing tests 
(e.g. `NetworkOutputBufferSpec`) are unaffected.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to