Ma77Ball commented on code in PR #5545:
URL: https://github.com/apache/texera/pull/5545#discussion_r3383434100
##########
config-service/src/main/scala/org/apache/texera/service/resource/ConfigResource.scala:
##########
Review Comment:
Moved `defaultDataTransferBatchSize` out of `/gui` into a new `/amber`
endpoint, and updated the frontend to fetch it there.
##########
config-service/src/main/scala/org/apache/texera/service/resource/ConfigResource.scala:
##########
@@ -22,6 +22,7 @@ package org.apache.texera.service.resource
import jakarta.annotation.security.{PermitAll, RolesAllowed}
import jakarta.ws.rs.core.MediaType
import jakarta.ws.rs.{GET, Path, Produces}
+import org.apache.texera.amber.config.ApplicationConfig
Review Comment:
`ApplicationConfig` actually lives in `common/config`, not the amber module,
so config-service does not depend on amber (the package is just named `amber`).
I added a short comment at the import to make that clear. Let me know if you'd
still prefer it organized differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
