Re: [PR] fix(file-service): apply LakeFS error handling to all call sites [texera]

[via GitHub]

aicam commented on PR #5607:
URL: https://github.com/apache/texera/pull/5607#issuecomment-4675718060

   > Hi @aicam , yes tested it locally to be sure. Ran the file-service from 
this branch inside the full single-node docker stack (everything else same), 
then just used the app normally in the browser:
   > 
   > Workflow:
   > 
   > * created a dataset + uploaded a csv = multipart upload went through fine, 
committed as v1, file renders in the viewer
   > * downloaded the single file and the version zip = both match the original 
exactly
   > * pointed a CSV File Scan operator at the dataset file and ran the 
workflow = completed, all 3 rows came through
   > 
   > also tried hitting a missing file and got a clean 404 with the new "LakeFS 
resource not found" message instead of a raw 500, so the handler is doing its 
thing outside the failure-injection tests too.
   > 
   > <img alt="08-dataset-created" width="1440" height="900" 
src="https://private-user-images.githubusercontent.com/149845903/606111578-dcb5bc38-3740-4822-bca4-b38ff2b458ab.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODExMzQ3OTIsIm5iZiI6MTc4MTEzNDQ5MiwicGF0aCI6Ii8xNDk4NDU5MDMvNjA2MTExNTc4LWRjYjViYzM4LTM3NDAtNDgyMi1iY2E0LWIzOGZmMmI0NThhYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDYxMFQyMzM0NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yOTRhZmRiYjFiYTVhYTZjY2UxYmY3NDU3OGRlNzQ0YTBiMzliNTAxMGE5MmRiN2I1Y2RhNjAyYjYyOWNkYmVhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.MpckTR6vcB3zfad8BrD8Ecjb6bv8vmNFgOk9YjSl818";>
 <img alt="11-version-created" width="1440" height="900" 
src="https://private-user-images.githubusercont
 
ent.com/149845903/606111581-5dc58691-d213-40c5-8483-ae59bac3ff07.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODExMzQ3OTIsIm5iZiI6MTc4MTEzNDQ5MiwicGF0aCI6Ii8xNDk4NDU5MDMvNjA2MTExNTgxLTVkYzU4NjkxLWQyMTMtNDBjNS04NDgzLWFlNTliYWMzZmYwNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDYxMFQyMzM0NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wOGNhMWI4YWMyYzU5MzY5YmJmZGY2ZTU2OTRkYzQ4OTIzOGE2NGVmNTY2ZTdiNjFiOTU2YjNkMTAyZGU3NmM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.-J4MXisUaXKNqTE9hfyDhM-WT6mmwqy3wYEzkB3Nplg">
 <img alt="22-file-picked" width="1440" height="900" 
src="https://private-user-images.githubusercontent.com/149845903/606111582-e9061525-81aa-4edc-812a-9fc4398046b3.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.e
 
yJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODExMzQ3OTIsIm5iZiI6MTc4MTEzNDQ5MiwicGF0aCI6Ii8xNDk4NDU5MDMvNjA2MTExNTgyLWU5MDYxNTI1LTgxYWEtNGVkYy04MTJhLTlmYzQzOTgwNDZiMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDYxMFQyMzM0NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MDNkMmIyNTU3YmUzMjI4ZTZmZjQwNGIyZTBlYjFmNzM2OWM0ZDVhZTE0MGE2OWYxNjhjMGM2MDdmMTQ1MTBhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.newCNLgS2Yt6TzNneJT_A1Ve2dYyNLPegczEDP_gmbA">
 <img alt="42-run-done" width="1440" height="900" 
src="https://private-user-images.githubusercontent.com/149845903/606111583-6d32ca39-cfd6-4b80-902d-0c8e13691cc5.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODExMzQ3OTIsIm5
 
iZiI6MTc4MTEzNDQ5MiwicGF0aCI6Ii8xNDk4NDU5MDMvNjA2MTExNTgzLTZkMzJjYTM5LWNmZDYtNGI4MC05MDJkLTBjOGUxMzY5MWNjNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDYxMFQyMzM0NTJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iM2Q5NzZhNDRhMzFlNGViOTY2ZTYxNGE4MjExMWQ1ZmUxMTkxYzJjZTFkZGQ5ZGI5N2Q4ZGYzMDgyNjBlYTZhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.CTTMlwHd9asPA4ILcL0DI-BWGTmmZtJZCLHywQrvZ2M">
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@texera.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org