suyashj1231 commented on code in PR #5607:
URL: https://github.com/apache/texera/pull/5607#discussion_r3400664656
##########
file-service/src/test/scala/org/apache/texera/service/MockLakeFS.scala:
##########
@@ -80,7 +99,7 @@ trait MockLakeFS extends ForAllTestContainer with
BeforeAndAfterAll { self: Suit
"LAKEFS_BLOCKSTORE_TYPE" -> "s3",
"LAKEFS_BLOCKSTORE_S3_FORCE_PATH_STYLE" -> "true",
"LAKEFS_BLOCKSTORE_S3_ENDPOINT" ->
s"http://${minio.container.getNetworkAliases.get(0)}:9000",
- "LAKEFS_BLOCKSTORE_S3_PRE_SIGNED_ENDPOINT" -> "http://localhost:9000";,
+ "LAKEFS_BLOCKSTORE_S3_PRE_SIGNED_ENDPOINT" ->
s"http://localhost:$minioHostPort";,
Review Comment:
Nope, that one stays 9000, it's LakeFS reaching MinIO inside the Docker
network, and MinIO still listens on 9000 there. $minioHostPort is only for the
host side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
