SarahAsad23 commented on code in PR #5613:
URL: https://github.com/apache/texera/pull/5613#discussion_r3399205215
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:
##########
@@ -472,28 +472,40 @@
</ng-template>
<nz-collapse-panel [nzHeader]="systemHeaderTpl">
<div class="system-panel-inner">
- <div class="package-header-row">
- <div class="package-column-label">Package</div>
- <div class="package-column-label">Version</div>
+ <div
+ *ngIf="systemPackagesLoading"
+ class="system-loading">
+ <span
+ nz-icon
+ nzType="loading"
+ nzTheme="outline"></span>
+ Fetching system packages…
</div>
- <div
- *ngFor="let pkg of systemPackages"
- class="package-row system-row">
- <div class="system-package-inputs">
- <input
- nz-input
- class="system-input"
- [disabled]="true"
- [ngModel]="pkg.name" />
+ <ng-container *ngIf="!systemPackagesLoading">
+ <div class="package-header-row">
+ <div class="package-column-label">Package</div>
+ <div class="package-column-label">Version</div>
Review Comment:
Removing `system-requirements-lock.txt` changes how system packages are
loaded. Previously, the package list was available immediately from the lock
file. With the new approach, the system package set is generated on demand by
creating a temporary environment, installing the requirements, and running pip
freeze, which introduces a noticeable delay on the initial load.
The UI changes are simply there to handle this new loading state and provide
feedback to the user while the system packages are being resolved. Since the
backend change directly impacts the user experience of the existing PVE
feature, I felt it made sense to include the corresponding UI updates in the
same PR. I could split them into a separate PR, but I'd prefer to keep them
together.
UI for reference:
<img width="974" height="474" alt="Screenshot 2026-06-11 at 2 10 40 PM"
src="https://github.com/user-attachments/assets/655b45c6-0994-427d-8a3b-a95eb889afa2";
/>
<img width="966" height="593" alt="Screenshot 2026-06-11 at 2 10 58 PM"
src="https://github.com/user-attachments/assets/2b80d0f5-e7cf-45d8-b835-bcee89451e6f";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
