Yicong-Huang commented on code in PR #5613:
URL: https://github.com/apache/texera/pull/5613#discussion_r3399943021
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.html:
##########
@@ -472,28 +472,40 @@
</ng-template>
<nz-collapse-panel [nzHeader]="systemHeaderTpl">
<div class="system-panel-inner">
- <div class="package-header-row">
- <div class="package-column-label">Package</div>
- <div class="package-column-label">Version</div>
+ <div
+ *ngIf="systemPackagesLoading"
+ class="system-loading">
+ <span
+ nz-icon
+ nzType="loading"
+ nzTheme="outline"></span>
+ Fetching system packages…
</div>
- <div
- *ngFor="let pkg of systemPackages"
- class="package-row system-row">
- <div class="system-package-inputs">
- <input
- nz-input
- class="system-input"
- [disabled]="true"
- [ngModel]="pkg.name" />
+ <ng-container *ngIf="!systemPackagesLoading">
+ <div class="package-header-row">
+ <div class="package-column-label">Package</div>
+ <div class="package-column-label">Version</div>
Review Comment:
I still suggest you separate them. For UI changes we need to see screenshots
on the PR description, and you are mixing a fix and a feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
