PG1204 commented on code in PR #5626: URL: https://github.com/apache/texera/pull/5626#discussion_r3405051238
########## frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.browser.spec.ts: ########## Review Comment: > I thought we have this `workflow-editor.browser.spec.ts` already, how come this PR adds a file? I think the .spec.ts file you are referring to is workflow-editor.component.spec.ts if I'm not wrong which was previously the only file routed to test-browser via the explicit include entry, so it was effectively the workflow-editor browser spec, just without the conventional name. This PR isolates the six tests that genuinely need a real browser (jQuery mousedown/dblclick dispatch on JointJS cell views, SVG hit-testing on blank-area paper clicks) into a properly-named sibling file, and drops the now-redundant explicit include entry from angular.json (commit 10b85f65c). The remaining tests in workflow-editor.component.spec.ts are jsdom-compatible and run under the default test target only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
