PG1204 commented on code in PR #5626:
URL: https://github.com/apache/texera/pull/5626#discussion_r3407051467
##########
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts:
##########
@@ -285,114 +245,11 @@ describe("WorkflowEditorComponent", () => {
dragDropService = TestBed.inject(DragDropService);
// detect changes to run ngAfterViewInit and bind Model
jointUIService = TestBed.inject(JointUIService);
- nzModalService = TestBed.inject(NzModalService);
undoRedoService = TestBed.inject(UndoRedoService);
workflowVersionService = TestBed.inject(WorkflowVersionService);
fixture.detectChanges();
});
- // TODO(#3614): the following four mouse/click-event tests rely on JointJS
Review Comment:
Good catch, I'll add #3614 to the related-issues section in the PR
description.
The lineage is as follows:
#3614 (original bug) -> PR #5146 (fix; commented out the 6 tests under
TODO(#3614)) -> #5318 (issue to restore them) -> this PR (closes #5318).
The TODO(#3614) comment was a breadcrumb pointing back to that origin and
removing it is correct because we're restoring the tests, but you're right that
the PR itself stays related to #3614. Updated in PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
