carloea2 commented on code in PR #5603:
URL: https://github.com/apache/texera/pull/5603#discussion_r3417919086
##########
amber/src/main/python/core/models/schema/attribute_type.py:
##########
@@ -78,6 +81,53 @@ class AttributeType(Enum):
}
+FROM_STRING_PARSER_MAPPING = {
Review Comment:
Can we discuss this further?
I believe it is good where it is for the next reason:
The parser mapping in attribute_type.py is there because this is still
shared AttributeType string-to-Python conversion behavior. The
UI-parameter-specific unsupported-type validation now lives in _parse.
It is easy to move just wanted to see if we can keep it where it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
