Yicong-Huang commented on code in PR #6240:
URL: https://github.com/apache/texera/pull/6240#discussion_r3541379493
##########
frontend/src/app/workspace/service/validation/validation-workflow.service.ts:
##########
@@ -388,6 +388,13 @@ export class ValidationWorkflowService {
link => validOperatorIds.has(link.source.operatorID) &&
validOperatorIds.has(link.target.operatorID)
);
- return new WorkflowGraph(validOperators, validLinks,
texeraGraph.getAllCommentBoxes());
+ // This graph is a throwaway used only to build a logical plan for
compilation/validation; it is read once and
+ // never destroyed. Pass enableSharedEditing=false so it does not open
(and leak) a /rtc WebSocket per edit.
+ return new WorkflowGraph(
+ validOperators,
+ validLinks,
+ texeraGraph.getAllCommentBoxes(),
+ /* enableSharedEditing */ false
Review Comment:
-1 on this change. WorkflowGraph should not describe if shared editing is
enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
