Yicong-Huang commented on code in PR #6336:
URL: https://github.com/apache/texera/pull/6336#discussion_r3564486921
##########
.github/scripts/smoke-boot.sh:
##########
@@ -56,8 +56,13 @@ echo "smoke-boot: launching '$launcher' (port=$port
timeout=${timeout}s)"
pid=$!
# Runtime classpath / linkage / module failures -- the class of regression this
-# check exists to catch.
-crash_re='NoClassDefFoundError|ClassNotFoundException|LinkageError|NoSuchMethodError|AbstractMethodError|ExceptionInInitializerError|IncompatibleClassChangeError|requires
Jackson Databind'
+# check exists to catch. Match the exception as an actual *thrown* type -- a
+# fully-qualified java.lang.* name, or an "Exception in thread" header -- not
the
+# bare class name, which also shows up in harmless informational log prose
(e.g.
+# jOOQ prints a random "tip of the day" banner naming NoClassDefFoundError /
+# ClassNotFoundException). Regression test: .github/scripts/test_smoke_boot.sh.
+# See https://github.com/apache/texera/issues/6332.
+crash_re='java\.lang\.(NoClassDefFoundError|ClassNotFoundException|LinkageError|NoSuchMethodError|AbstractMethodError|ExceptionInInitializerError|IncompatibleClassChangeError)|Exception
in thread|requires Jackson Databind'
Review Comment:
The way to check exception names in stdout/stderr is too fragile. it could
easily be flaky if in the future we print out some of the exception name.
##########
.github/scripts/smoke-boot.sh:
##########
@@ -56,8 +56,13 @@ echo "smoke-boot: launching '$launcher' (port=$port
timeout=${timeout}s)"
pid=$!
# Runtime classpath / linkage / module failures -- the class of regression this
-# check exists to catch.
-crash_re='NoClassDefFoundError|ClassNotFoundException|LinkageError|NoSuchMethodError|AbstractMethodError|ExceptionInInitializerError|IncompatibleClassChangeError|requires
Jackson Databind'
+# check exists to catch. Match the exception as an actual *thrown* type -- a
+# fully-qualified java.lang.* name, or an "Exception in thread" header -- not
the
+# bare class name, which also shows up in harmless informational log prose
(e.g.
+# jOOQ prints a random "tip of the day" banner naming NoClassDefFoundError /
+# ClassNotFoundException). Regression test: .github/scripts/test_smoke_boot.sh.
+# See https://github.com/apache/texera/issues/6332.
+crash_re='java\.lang\.(NoClassDefFoundError|ClassNotFoundException|LinkageError|NoSuchMethodError|AbstractMethodError|ExceptionInInitializerError|IncompatibleClassChangeError)|Exception
in thread|requires Jackson Databind'
Review Comment:
can we in addition also check the return code from the process? if the
process crashed, we get non 0 return code right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
