mengw15 commented on code in PR #6336:
URL: https://github.com/apache/texera/pull/6336#discussion_r3564896586
##########
.github/scripts/smoke-boot.sh:
##########
@@ -56,8 +56,13 @@ echo "smoke-boot: launching '$launcher' (port=$port
timeout=${timeout}s)"
pid=$!
# Runtime classpath / linkage / module failures -- the class of regression this
-# check exists to catch.
-crash_re='NoClassDefFoundError|ClassNotFoundException|LinkageError|NoSuchMethodError|AbstractMethodError|ExceptionInInitializerError|IncompatibleClassChangeError|requires
Jackson Databind'
+# check exists to catch. Match the exception as an actual *thrown* type -- a
+# fully-qualified java.lang.* name, or an "Exception in thread" header -- not
the
+# bare class name, which also shows up in harmless informational log prose
(e.g.
+# jOOQ prints a random "tip of the day" banner naming NoClassDefFoundError /
+# ClassNotFoundException). Regression test: .github/scripts/test_smoke_boot.sh.
+# See https://github.com/apache/texera/issues/6332.
+crash_re='java\.lang\.(NoClassDefFoundError|ClassNotFoundException|LinkageError|NoSuchMethodError|AbstractMethodError|ExceptionInInitializerError|IncompatibleClassChangeError)|Exception
in thread|requires Jackson Databind'
Review Comment:
Done in `cf1da71` — reworked to exactly this. `smoke-boot.sh` now decides
from the process: reaching LISTEN is a healthy boot; **exiting before LISTEN is
a crash, and it reports the exit code**; timeout is a hang. The `crash_re`
stdout/stderr scan is gone, so log text — the jOOQ tip, or any future
exception-name prose — can't trip it.
The one case this intentionally gives up is a service that logs a linkage
error but still reaches LISTEN; I don't think that's worth a fragile string
match — a health-check on the admin endpoint would be a more robust signal if
we ever want it.
The regression test now drives `smoke-boot.sh` end-to-end (a healthy service
that logs the jOOQ tip passes; a crasher and a hang fail).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
