PG1204 commented on code in PR #6446:
URL: https://github.com/apache/texera/pull/6446#discussion_r3598340951
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitAccessResource.scala:
##########
@@ -152,18 +152,22 @@ class ComputingUnitAccessResource {
}
Review Comment:
confirmed that there's no ExceptionMapper for IllegalArgumentException (only
UnauthorizedExceptionMapper), so it was surfacing as a 500. Switched to JAX-RS
exceptions: ForbiddenException (403) for the permission check and
BadRequestException (400) for the unknown-email case, matching the
DatasetAccessResource/WorkflowAccessResource convention. Tests now assert the
resolved status codes (403/400).
addressed in 91ad863
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
