PG1204 commented on code in PR #6446:
URL: https://github.com/apache/texera/pull/6446#discussion_r3598345867
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/ComputingUnitAccessResource.scala:
##########
@@ -179,10 +183,11 @@ class ComputingUnitAccessResource {
throw new IllegalArgumentException("User does not have permission to
revoke access")
}
Review Comment:
fixed, revokeAccess now throws ForbiddenException (403) for the permission
check and BadRequestException (400) for the unknown-email case, same as
grantAccess. Tests assert the resolved status codes.
addressed in
https://github.com/apache/texera/commit/91ad863aa74374eb5a280d890fd822cc5720938f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
