mengw15 commented on code in PR #6377:
URL: https://github.com/apache/texera/pull/6377#discussion_r3605517751
##########
.github/workflows/build.yml:
##########
@@ -639,6 +639,19 @@ jobs:
# amber/src/main/resources/web-config.yml (port 8080).
if: matrix.os == 'ubuntu-latest'
run: .github/scripts/smoke-boot.sh
"/tmp/dists/amber-*/bin/texera-web-application" 8080
+ - name: Smoke-test computing-unit-master boots
+ # computing-unit-master boots on postgres only, like texera-web: main
+ # starts a LOCAL Pekko actor master (clusterMode defaults to false with
+ # no --cluster arg, so no external seed/discovery and the cluster-only
+ # checkip.amazonaws.com lookup is never reached), then run() calls
+ # SqlServer.initConnection against the postgres provisioned above. The
+ # boot-time result-store cleanup is gated on
+ # ApplicationConfig.cleanupAllExecutionResults, which defaults to
false,
+ # so no iceberg / S3 access. Config resolves via Utils.amberHomePath to
+ # amber/src/main/resources/computing-unit-master-config.yml (port
8085).
+ # Reuses the amber dist built + unzipped above for the texera-web boot.
+ if: matrix.os == 'ubuntu-latest'
+ run: .github/scripts/smoke-boot.sh
"/tmp/dists/amber-*/bin/computing-unit-master" 8085
Review Comment:
Looked at `ComputingUnitWorker` — it doesn't fit this smoke test the same
way:
- **No fixed port to probe.** `startActorWorker` binds
`artery.canonical.port = 0` (random) and runs no HTTP server; `smoke-boot.sh`
needs a known port (the master works because of its Dropwizard `:8085`).
- **A worker's health = "joined the cluster,"** which needs a master/seed at
`:2552` first — standalone it just retries and stays up, so "didn't crash"
proves nothing. A real test is master + worker + a cluster-membership assertion.
- **Linkage coverage is mostly shared** — same amber dist/classpath; the
worker's only unique path is `startActorWorker` vs `startActorMaster`.
So I'd scope this PR to the master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
