Copilot commented on code in PR #6492: URL: https://github.com/apache/texera/pull/6492#discussion_r3607545771
########## amber/src/test/python/core/architecture/rpc/test_async_rpc_server.py: ########## @@ -0,0 +1,511 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import asyncio + +import grpclib.const +import pytest +from grpclib.const import Cardinality + +from core.architecture.rpc import async_rpc_server as async_rpc_server_module +from core.architecture.rpc.async_rpc_server import AsyncRPCServer +from core.models.internal_queue import DCMElement, InternalQueue +from core.util import get_one_of, set_one_of +from proto.org.apache.texera.amber.core import ( + ActorVirtualIdentity, + ChannelIdentity, +) +from proto.org.apache.texera.amber.engine.architecture.rpc import ( + AsyncRpcContext, + ControlError, + ControlInvocation, + ControlRequest, + ControlReturn, + EmptyRequest, + ErrorLanguage, + ReturnInvocation, + StringResponse, +) + + +def _make_handler(func) -> grpclib.const.Handler: + """Builds a real grpclib Handler namedtuple around an async callable. + + AsyncRPCServer only ever touches `.func`, but using the real namedtuple + keeps the stub shape identical to what AsyncRPCHandlerInitializer yields. + """ + return grpclib.const.Handler( + func, Cardinality.UNARY_UNARY, ControlRequest, ControlReturn + ) + + +def _make_server(handlers: dict) -> AsyncRPCServer: + """AsyncRPCServer with the given handler map and a real InternalQueue. + + Bypasses __init__ because building a real Context (and therefore a real + AsyncRPCHandlerInitializer) drags in the whole worker; receive() only + needs `_handlers` and `_output_queue`. + """ + server = AsyncRPCServer.__new__(AsyncRPCServer) + server._handlers = handlers + server._output_queue = InternalQueue() + return server + + +def _make_invocation( + method_name: str, command_id: int, context: AsyncRpcContext = None +) -> ControlInvocation: Review Comment: _make_invocation() annotates context as AsyncRpcContext but defaults it to None, which is a type mismatch and makes static checking harder. Update the annotation to explicitly allow None. ########## amber/src/test/python/core/architecture/rpc/test_async_rpc_server.py: ########## @@ -0,0 +1,511 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import asyncio + +import grpclib.const +import pytest +from grpclib.const import Cardinality + +from core.architecture.rpc import async_rpc_server as async_rpc_server_module +from core.architecture.rpc.async_rpc_server import AsyncRPCServer +from core.models.internal_queue import DCMElement, InternalQueue +from core.util import get_one_of, set_one_of +from proto.org.apache.texera.amber.core import ( + ActorVirtualIdentity, + ChannelIdentity, +) +from proto.org.apache.texera.amber.engine.architecture.rpc import ( + AsyncRpcContext, + ControlError, + ControlInvocation, + ControlRequest, + ControlReturn, + EmptyRequest, + ErrorLanguage, + ReturnInvocation, + StringResponse, +) + + +def _make_handler(func) -> grpclib.const.Handler: + """Builds a real grpclib Handler namedtuple around an async callable. + + AsyncRPCServer only ever touches `.func`, but using the real namedtuple + keeps the stub shape identical to what AsyncRPCHandlerInitializer yields. + """ + return grpclib.const.Handler( + func, Cardinality.UNARY_UNARY, ControlRequest, ControlReturn + ) Review Comment: _make_handler() is documented as wrapping an async callable, but several tests pass None. That makes the helper less representative of real grpclib handlers and could hide regressions if AsyncRPCServer starts touching handler.func in more places. Consider defaulting None to a no-op async function so the handler always contains a callable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
