eugenegujing commented on PR #6491: URL: https://github.com/apache/texera/pull/6491#issuecomment-5010647848
> #### ๐ค texera-dev review > ๐ฆ **1 must-fix ยท 0 advisory ยท 0 polish** โ requesting changes only on the commit scope; the test code itself is a clean characterization suite. > > ### ๐ Title & commit scope (1) > * ๐ด **must-fix** โ retitle `test(amber)` โ `test(pyamber): add unit test coverage for InputManager`. The PR title becomes the squash-merge commit message, and the tested code is the Python worker engine (`pyamber`), not the Scala engine (`amber`). AGENTS.md scopes the Python engine `pyamber` (its test example is `test(pyamber): โฆ`), the `pyamber` codecov flag moved (+0.54%, not `amber`), and the near-identical merged PR is `test(pyamber): add unit test coverage for InternalQueue`. @Yicong-Huang fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
