aglinxinyuan commented on PR #6730: URL: https://github.com/apache/texera/pull/6730#issuecomment-5041037695
Looked into all five Copilot findings — they're non-issues; details below. Pushed one comment-only commit (48efa63) to spell out the first point. **`always()` on the staging / artifact steps (`build.yml`).** Both steps use `if: matrix.os == 'ubuntu-latest' && inputs.backport_target_branch == '' && !cancelled()`. Because the expression contains a status-check function (`!cancelled()`), GitHub does **not** auto-wrap it with the implicit `success()` — [per the docs](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#status-check-functions), `success()` is only inserted when the `if` contains none of the status functions. So staging already runs when the unit or browser tests fail; it only skips a cancelled run. That reproduces the old `always()`/`!cancelled()` behavior (partial coverage + JUnit still staged), and staging from a cancelled/timed-out run is undesirable since the reports are incomplete. Added a comment saying exactly this. **Empty `override_pr` on push runs (`codecov-upload.yml`).** The `codecov-action` wrapper only emits a flag when its value is non-empty. From `dist/codecov.sh` at the pinned v7.0.0 SHA: ```sh k_arg() { if [ -n "$(eval echo \$"CC_$1")" ]; then echo "--$(lower "$1")"; fi } v_arg() { if [ -n "$(eval echo \$"CC_$1")" ]; then echo "$(eval echo \$"CC_$1")"; fi } ... CC_ARGS+=( $(k_arg PR) $(v_arg PR)) CC_ARGS+=( $(k_arg SHA) $(v_arg SHA)) CC_ARGS+=( $(k_arg BRANCH) $(v_arg BRANCH)) ``` So on a push to main `pr-number.txt` is empty → `CC_PR` is empty → `--pr` is omitted entirely (not passed as `--pr ""`). `override_commit`/`override_branch` behave the same way. No empty-arg failure and no mis-association — the push commit is still keyed correctly from the stashed `commit-sha.txt` (`= github.sha`), so a PR/push split isn't needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
