aglinxinyuan commented on PR #6730: URL: https://github.com/apache/texera/pull/6730#issuecomment-5043300994
Done — pushed. Three things: **Failure notification (your main concern).** Added a `notify-failure` job: if a coverage upload fails, it comments on the PR with a link to the failed run + the `run_id` to manually dispatch — same idea as auto-backport. Success stays silent since Codecov comments itself. And the delayed/no-runner case is covered by design: if the job is queued and nothing runs, *no* comment appears at all — which is your signal to go look. (I made the coverage upload fail hard so a real error actually trips this; test-results stay best-effort so a Test-Analytics hiccup doesn't false-alarm.) **All flags in one PR.** Every flag now stages a `codecov-<flag>` artifact in the build and re-uploads through the deferred workflow — frontend, amber, amber-integration, pyamber, agent-service, and the 6 platform services. **Batching to cut Codecov calls.** We can't, not without dropping the per-flag model: Codecov requires one upload per flag (flags in a single upload apply to *all* its files, and carryforward — which our `codecov.yml` relies on — needs the flag set at upload time), and there's no path-based auto-assignment. The token is what relieves the pressure anyway — the *tokenless* rate limit was the problem, and authenticated uploads aren't subject to it, so call count isn't the lever. (Components could collapse to one upload but would mean giving up flags + carryforward — a separate, bigger change.) One thing I'll confirm on the first live run after merge: the test-results (Test Analytics) upload is best-effort, so I want to eyeball that each flag's JUnit files are found — but that's separate from the coverage report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
