Yicong-Huang commented on code in PR #6819:
URL: https://github.com/apache/texera/pull/6819#discussion_r3649603336
##########
frontend/src/app/common/service/computing-unit/computing-unit-status/computing-unit-status.service.spec.ts:
##########
@@ -294,4 +294,131 @@ describe("ComputingUnitStatusService", () => {
vi.useRealTimers();
}
});
+
+ describe("selectComputingUnit() cache-miss and guard branches", () => {
Review Comment:
The `wid === undefined` no-op branch of `selectComputingUnit` (the
`isDefined(wid)` guard in `trySelect`, computing-unit-status.service.ts:164) is
still unexercised — no test calls `selectComputingUnit(undefined, ...)`. One
test asserting the websocket is not opened would close the last uncovered
branch and match the ~100% coverage claim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
