aglinxinyuan commented on code in PR #6819:
URL: https://github.com/apache/texera/pull/6819#discussion_r3671323573
##########
frontend/src/app/common/service/computing-unit/computing-unit-status/computing-unit-status.service.spec.ts:
##########
@@ -294,4 +294,131 @@ describe("ComputingUnitStatusService", () => {
vi.useRealTimers();
}
});
+
+ describe("selectComputingUnit() cache-miss and guard branches", () => {
Review Comment:
Added — "does nothing when the workflow id is undefined" seeds the cache so
the cached-unit path is taken (making `isDefined(wid)` the only remaining
gate), calls `selectComputingUnit(undefined, 7)`, and asserts `openWebsocket`
was not called, the selected unit stays null, and currentConnectedWid/Cuid
remain undefined. Spec is at 27 tests, format:ci clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
