Copilot commented on code in PR #6913:
URL: https://github.com/apache/texera/pull/6913#discussion_r3697398654
##########
amber/src/main/python/core/runnables/main_loop.py:
##########
@@ -375,14 +418,44 @@ def _process_state_frame(self, frame: StateFrame) -> None:
# by the outer LoopStart's id stamped on the envelope (a
first-entry
# state has no stamp): step one level deeper and forward, keeping
# the outer loop's id.
+ #
+ # The UNstamped case deliberately does NOT mirror the Loop End
+ # branch below: it falls through to the operator, whose
+ # process_state MERGES the incoming keys into the loop variables.
+ # That asymmetry is forced, not an oversight. The back-edge writes
Review Comment:
In the LoopStart pass-through branch (which only runs when
`frame.loop_start_id` is non-empty), the comment starts with “The UNstamped
case…” which is easy to misread as describing the code path being executed.
Rewording it to explicitly call out that it refers to the *other* (unstamped)
case would make the logic clearer for future maintainers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
