aglinxinyuan commented on code in PR #6913:
URL: https://github.com/apache/texera/pull/6913#discussion_r3697407759
##########
amber/src/main/python/core/runnables/main_loop.py:
##########
@@ -375,14 +418,44 @@ def _process_state_frame(self, frame: StateFrame) -> None:
# by the outer LoopStart's id stamped on the envelope (a
first-entry
# state has no stamp): step one level deeper and forward, keeping
# the outer loop's id.
+ #
+ # The UNstamped case deliberately does NOT mirror the Loop End
+ # branch below: it falls through to the operator, whose
+ # process_state MERGES the incoming keys into the loop variables.
+ # That asymmetry is forced, not an oversight. The back-edge writes
Review Comment:
Good catch — fixed in 2e17962. The note was attached to the branch guarded
by `frame.loop_start_id`, which only runs for STAMPED frames, so opening with
"The UNstamped case ..." read as if it described the code right below it.
Moved it out of that branch to where an unstamped frame actually goes
(falling through to `process_input_state` at the bottom) and reworded to name
the path explicitly: "A LoopStart handles only the STAMPED case above. An
UNstamped counter-0 state at a LoopStart takes neither branch: it falls all the
way through ...".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
