Neilk1021 commented on code in PR #7055: URL: https://github.com/apache/texera/pull/7055#discussion_r3723080002
########## amber/src/main/scala/org/apache/texera/web/resource/auth/ExternalAuthProvisioner.scala: ########## @@ -0,0 +1,237 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.texera.web.resource.auth + +import com.typesafe.scalalogging.LazyLogging +import org.apache.texera.dao.SqlServer +import org.apache.texera.dao.jooq.generated.Tables.{AUTH_PROVIDER, USER} +import org.apache.texera.dao.jooq.generated.enums.{ProviderTypeEnum, UserRoleEnum} +import org.apache.texera.dao.jooq.generated.tables.daos.{AuthProviderDao, UserDao} +import org.apache.texera.dao.jooq.generated.tables.pojos.{AuthProvider, User} +import org.jooq.DSLContext + +import java.net.URI +import java.time.OffsetDateTime +import javax.ws.rs.NotAuthorizedException +import scala.util.chaining.scalaUtilChainingOps +import scala.util.Try + +/** + * A verified external identity (Google, Facebook, ...) reduced to the fields we + * persist. `avatar` is the complete URL the provider supplied, and is optional: + * `None` means the provider supplies no avatar, so the user's existing avatar column + * is left untouched rather than overwritten. + * + * `emailVerified` reports whether the provider itself vouches for `email`. It has no + * default on purpose: an email address is what links an external identity to an + * existing account, so treating an unverified one as trusted is an account-takeover + * path, and a defaulted flag is how that mistake comes back. + */ +final case class ExternalProfile( + providerType: ProviderTypeEnum, + providerId: String, + name: String, + email: String, + emailVerified: Boolean, + avatar: Option[String] = None +) + +object ExternalAuthProvisioner extends LazyLogging { + // ── avatar host allowlist ── + private val ALLOWED_AVATAR_HOST_SUFFIXES: Set[String] = Set( + "googleusercontent.com" + ) + + /** Allow an exact host or any subdomain of an allowlisted suffix. */ + private[auth] def isAllowedAvatarHost(host: String): Boolean = { + if (host == null || host.isEmpty) return false + val lower = host.toLowerCase + ALLOWED_AVATAR_HOST_SUFFIXES.exists(suffix => lower == suffix || lower.endsWith("." + suffix)) + } + + /** + * The avatar URL to persist, or `None` to leave the stored value alone. Anything that is not + * an http(s) URL on an allowlisted host is dropped rather than rejected: a surprising avatar + * is not a reason to deny someone a login, and treating it as "provider supplied no avatar" + * falls back to the initials avatar. + */ + private[auth] def sanitizedAvatar(profile: ExternalProfile): Option[String] = Review Comment: Reverting and migrating to a future pr! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
