Neilk1021 commented on code in PR #7055:
URL: https://github.com/apache/texera/pull/7055#discussion_r3723090525
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/admin/user/AdminUserResource.scala:
##########
@@ -72,14 +77,24 @@ class AdminUserResource {
@Path("/list")
@Produces(Array(MediaType.APPLICATION_JSON))
def list(): util.List[UserInfo] = {
+
+ val googleProvider = AUTH_PROVIDER.as("google_provider")
+ val localProvider = AUTH_PROVIDER.as("local_provider")
+
AdminUserResource.context
.select(
USER.UID,
USER.NAME,
USER.EMAIL,
- USER.GOOGLE_ID,
+ // fetchInto maps onto a Scala case class POSITIONALLY, not by name: a
case class has no
+ // no-arg constructor, so jOOQ falls through to ImmutablePOJOMapper.
So the column order
+ // below must track the UserInfo field order. `last_active_time`
landing on `lastLogin` two
+ // entries down only works because of that. The aliases are
documentation (both joins
+ // project a column called `provider_id`); they do not drive the
mapping.
+ googleProvider.PROVIDER_ID.as("googleId"),
+ localProvider.PROVIDER_ID.as("localHandle"),
Review Comment:
I decided to dorp the field and its join for now so theres not a dead column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
