Copilot commented on code in PR #7427: URL: https://github.com/apache/texera/pull/7427#discussion_r3742732201
########## CONTRIBUTING.md: ########## @@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b - `fix(ui): prevent racing of requests` - `chore(deps): bump numpy to version 2.0.0` +##### Choosing between `feat`, `fix`, and `refactor` + +The type depends on what happens to the behavior, not on how large the change is. + +| Your change | Type | +| ----------- | ---- | +| A functionality worked before and no longer does | `fix` | +| A functionality or a form of support never existed and you are adding it | `feat` | +| A functionality exists and you are removing support for it | `feat` | +| A functionality works but is hard to use, and you are reworking it | `feat` | +| The change leaves the user-facing behavior unchanged | `refactor` | + +`refactor` is a strong claim: it says the **user-facing** behavior is identical. The test suite is how you check that, but not every test carries the same weight. A test that pins a user-facing API is the contract — if you had to change one of its assertions to make the suite green, the behavior moved, and the PR is a `feat` or a `fix`. A test that pins internals, such as a private helper's signature, the call order between two collaborators, or the shape of an intermediate value, is mirroring the implementation; rewriting it alongside the code it mirrors is expected and still a `refactor`. + +##### Tests and dependency bumps + +Two cases use a two-part scope, written as `<type>(<area>, <module>): <description>`: + +| Your change | Title | +| ----------- | ----- | +| A test-only PR — adding or updating tests | `test(<module>): ...`, e.g. `test(amber): add marker replay specs` | +| Repairing a broken or flaky test | `fix(test, <module>): ...`, e.g. `fix(test, frontend): stabilize the dashboard spec` | +| A dependency bump that patches a CVE | `fix(deps, <module>): ...`, e.g. `fix(deps, pyamber): bump protobuf for CVE-2025-4565` | +| Any other dependency bump | `chore(deps, <module>): ...`, e.g. `chore(deps, frontend): bump numpy to 2.0.0` | Review Comment: The example for a non-CVE dependency bump uses `frontend` as the module scope for a NumPy bump, but NumPy is a Python dependency (it appears in `amber/requirements.txt`). This example should use a Python-related module scope (e.g., `pyamber`) to avoid misleading contributors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
