xuang7 commented on code in PR #7427: URL: https://github.com/apache/texera/pull/7427#discussion_r3742776816
########## CONTRIBUTING.md: ########## @@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b - `fix(ui): prevent racing of requests` - `chore(deps): bump numpy to version 2.0.0` +##### Choosing between `feat`, `fix`, and `refactor` + +The type depends on what happens to the behavior, not on how large the change is. + +| Your change | Type | +| ----------- | ---- | +| A functionality worked before and no longer does | `fix` | +| A functionality or a form of support never existed and you are adding it | `feat` | +| A functionality exists and you are removing support for it | `feat` | +| A functionality works but is hard to use, and you are reworking it | `feat` | Review Comment: Would it be clearer to define this in terms of user-facing behavior rather than whether the functionality is "hard to use"? For example, "Existing functionality is reworked in a way that intentionally changes user-facing behavior." ########## CONTRIBUTING.md: ########## @@ -54,6 +54,37 @@ Thank you for your interest in contributing to Texera! Please follow the steps b - `fix(ui): prevent racing of requests` - `chore(deps): bump numpy to version 2.0.0` +##### Choosing between `feat`, `fix`, and `refactor` + +The type depends on what happens to the behavior, not on how large the change is. + +| Your change | Type | +| ----------- | ---- | +| A functionality worked before and no longer does | `fix` | +| A functionality or a form of support never existed and you are adding it | `feat` | Review Comment: Would this case be considered a fix or a feat? For example, if the existing behavior is incorrect and the PR restores the intended behavior, but the functionality may never have worked correctly before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
