aglinxinyuan opened a new pull request, #7447:
URL: https://github.com/apache/texera/pull/7447
### What changes were proposed in this PR?
Deletes four self-contained amber files with no production caller. Every
entry is a whole-file deletion — no surviving file is edited. Pure deletion, no
behaviour change: **−575 lines**.
| Removed | Lines | Why it is dead |
| --- | ---: | --- |
| `engine/common/ElidableStatement.scala` | 34 | no caller; `elidable`
appears nowhere else in the repo |
| `engine/common/ElidableStatementSpec.scala` | 141 | covers only the above |
| `engine/architecture/logreplay/EmptyReplayLogger.scala` | 41 | null-object
superseded by `EmptyReplayLogManagerImpl` |
| `engine/architecture/logreplay/EmptyReplayLoggerSpec.scala` | 130 | covers
only the above |
| `engine/architecture/pythonworker/PythonWorkflowWorkerSpec.scala` | 201 |
every line is commented out, including `package` |
| `web/model/http/response/SchemaPropagationResponse.scala` | 28 | no
resource returns it; one repo-wide hit, itself |
**`EmptyReplayLogger`** is a no-op `ReplayLogger` the factory no longer
reaches:
```
ReplayLogManager.scala:51 -> EmptyReplayLogManagerImpl (implements the
no-ops inline, live)
ReplayLogManager.scala:109 -> new ReplayLoggerImpl() (the only
ReplayLogger built in main)
EmptyReplayLogger (never
instantiated)
```
**`ElidableStatement`** has no caller and no wiring — there are no
`-Xelide-below` scalac options anywhere in the build, so the object had no
effect even in principle.
**`PythonWorkflowWorkerSpec`** contributes zero test suites; it compiles to
a licence header. Its commented body targets APIs deleted long ago
(`InitializeOperatorLogicHandler`, `UpdateInputLinkingHandler`,
`OpenOperator`), so it cannot be un-commented as-is. Live
`PythonWorkflowWorker` coverage is in the `@IntegrationTest` e2e specs, which
this file does not participate in.
> Reviewer note: `ElidableStatement` and `EmptyReplayLogger` acquired unit
tests during the 2026 coverage work, which is why they currently look live. The
specs cover the dead code and nothing else, so they go with it. The live
siblings — `ReplayLoggerImpl`, `EmptyReplayLogManagerImpl`, the abstract
`ReplayLogger` — are untouched.
### Any related issues, documentation, discussions?
Closes #7445
### How was this PR tested?
Existing tests only — this PR adds none, since it removes code and the specs
that covered it.
Locally, from the repo root with Java 17:
- `sbt "WorkflowExecutionService/Test/compile"` — success (main and test
sources).
Verification that nothing references the removed files, re-runnable by a
reviewer:
```
git grep -n ElidableStatement EmptyReplayLogger SchemaPropagationResponse
PythonWorkflowWorkerSpec
git grep -in elidable # no -Xelide-below wiring anywhere
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
