gupta-sahil01 commented on code in PR #6437: URL: https://github.com/apache/texera/pull/6437#discussion_r3762215029
########## frontend/src/app/workspace/service/operator-recommendation/operator-recommendation.service.ts: ########## @@ -0,0 +1,152 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { Injectable } from "@angular/core"; +import { HttpClient } from "@angular/common/http"; +import { Observable, catchError, map, of } from "rxjs"; +import { OperatorLink, OperatorPredicate, Point } from "../../types/workflow-common.interface"; +import { WorkflowActionService } from "../workflow-graph/model/workflow-action.service"; +import { WorkflowUtilService } from "../workflow-graph/util/workflow-util.service"; +import { JointUIService } from "../joint-ui/joint-ui.service"; +import { GuiConfigService } from "../../../common/service/gui-config.service"; + +/** + * A single operator suggestion returned by the agent-service `/api/recommend` + * endpoint (apache/texera#5240). Mirrors the backend `OperatorRecommendation`. + */ +export interface OperatorRecommendation { + /** Recommended operator type; a real, catalog-known type. */ + operatorType: string; + /** Confidence in `[0, 1]`, monotonically non-increasing down the list. */ + score: number; + /** Short, human-readable rationale shown alongside the suggested operator. */ + reason: string; + /** Display name from operator metadata, when available. */ + userFriendlyName?: string; +} + +interface RecommendationResponse { + recommendations: OperatorRecommendation[]; + strategy: "hardcoded" | "llm"; +} + +/** + * Client for the ambient operator recommender. Asks the stateless agent-service + * endpoint what operators are likely to follow the one just added, and turns a + * chosen suggestion into a real operator wired onto the source's output port. + * + * The service never fails loudly: the recommender is a non-essential, ambient + * aid, so a backend error or a disabled feature simply yields no suggestions + * and the canvas behaves exactly as before. + */ +@Injectable({ + providedIn: "root", +}) +export class OperatorRecommendationService { + private static readonly RECOMMEND_API_URL = "/api/recommend"; + + // Horizontal gap between the source operator and a materialized suggestion. + private static readonly MATERIALIZE_GAP_X = 100; + + constructor( + private http: HttpClient, + private config: GuiConfigService, + private workflowActionService: WorkflowActionService, + private workflowUtilService: WorkflowUtilService + ) {} + + /** Whether the opt-in recommender feature is turned on for this deployment. */ + public isEnabled(): boolean { + return this.config.env.operatorRecommendationEnabled === true; + } + + /** + * Fetch ranked next-operator suggestions for the operator just added. + * + * Returns an empty list (never errors) when the feature is disabled, the + * operator has no output port to suggest from, or the backend call fails. + * + * @param operator the operator that was just added to the canvas + * @param limit maximum number of suggestions to request + */ + public getRecommendations(operator: OperatorPredicate, limit?: number): Observable<OperatorRecommendation[]> { + // A source-less/output-less operator (e.g. a chart sink) has no output port Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
