Yicong-Huang commented on code in PR #6437:
URL: https://github.com/apache/texera/pull/6437#discussion_r3769693256
##########
frontend/src/app/workspace/component/workflow-editor/workflow-editor.component.ts:
##########
@@ -109,6 +113,22 @@ export class WorkflowEditorComponent implements OnInit,
AfterViewInit, OnDestroy
position: { x: number; y: number };
} | null = null;
+ // Ambient operator recommender state (apache/texera#5240). Holds the faded
+ // next-operator suggestions anchored on the output port of the
+ // operator that was just added; null when nothing is being suggested.
+ public operatorSuggestion: {
Review Comment:
Verified: the component-side symbols are all `nextOperatorSuggestion*` now
(119, 1774-1953) and the SCSS classes match, so `DragDropService` is the sole
owner of `operatorSuggestion*` / `SUGGESTION_DISTANCE_THRESHOLD`. Resolving.
On your open question — leave the config flag alone.
`operatorRecommendationEnabled` and its env var are deployment-facing names
that should track the backend feature, and the collision I was worried about
was between two sets of *component* symbols. Renaming five files to fix a
problem that no longer exists isn't worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
