tanishqgandhi1908 commented on code in PR #6860:
URL: https://github.com/apache/texera/pull/6860#discussion_r3779175422
##########
common/config/src/main/scala/org/apache/texera/common/config/EnvironmentalVariable.scala:
##########
@@ -36,6 +36,8 @@ object EnvironmentalVariable {
* FileService related endpoint
*/
val ENV_FILE_SERVICE_GET_PRESIGNED_URL_ENDPOINT =
"FILE_SERVICE_GET_PRESIGNED_URL_ENDPOINT"
+ val ENV_FILE_SERVICE_GET_MODEL_PRESIGNED_URL_ENDPOINT =
Review Comment:
Renamed the dataset presign env var to
FILE_SERVICE_GET_DATASET_PRESIGNED_URL_ENDPOINT (key + value) so it's
consistent with the model one, and updated everywhere it's set/read (k8s
templates, local-dev, computing-unit manager, python client). Model needs its
own endpoint for model access control that lands with the model API in #6498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
