tanishqgandhi1908 commented on code in PR #6860:
URL: https://github.com/apache/texera/pull/6860#discussion_r3781189978
##########
common/config/src/main/scala/org/apache/texera/common/config/EnvironmentalVariable.scala:
##########
@@ -35,7 +35,10 @@ object EnvironmentalVariable {
/**
* FileService related endpoint
*/
- val ENV_FILE_SERVICE_GET_PRESIGNED_URL_ENDPOINT =
"FILE_SERVICE_GET_PRESIGNED_URL_ENDPOINT"
+ val ENV_FILE_SERVICE_GET_DATASET_PRESIGNED_URL_ENDPOINT =
+ "FILE_SERVICE_GET_DATASET_PRESIGNED_URL_ENDPOINT"
+ val ENV_FILE_SERVICE_GET_MODEL_PRESIGNED_URL_ENDPOINT =
+ "FILE_SERVICE_GET_MODEL_PRESIGNED_URL_ENDPOINT"
Review Comment:
All in-repo sites move together in the same release (k8s templates,
local-dev, single-node .env, computing-unit manager, python + JVM clients), so
there's no silent break. Kept it a clean rename instead of carrying a
deprecated alias
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
