aglinxinyuan commented on PR #7452: URL: https://github.com/apache/texera/pull/7452#issuecomment-5299907513
Confirmed unused, with history to back it: `git log -S "new EmptyReplayLogger" --all` returns only the #5554 spec commits and this removal, so no production commit ever constructed it. The live null object is `EmptyReplayLogManagerImpl` one layer up, which inherits the trait's non-logging `withFaultTolerant` and needs no logger. Both advisories addressed: - Corrected the description — it claimed the null-object role "moved up a layer", but `69b7f9bc1` (#2230) added all four classes in one commit, so `EmptyReplayLogger` was simply never wired. - `ReplayLogger` is indeed down to one subclass with no declared-type site. Filed as #7673 rather than folded in here, since collapsing it edits live code while this PR is a pure dead-code deletion. No diff change, so the approval still applies to the same tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
