aicam commented on code in PR #7762: URL: https://github.com/apache/texera/pull/7762#discussion_r3832304105
########## file-service/src/main/scala/org/apache/texera/service/type/dataset/DatasetFileNode.scala: ########## @@ -24,9 +24,11 @@ import org.apache.texera.amber.core.storage.ResourceType import scala.collection.mutable -// DatasetFileNode represents a unique file in dataset, its full path is in the format of: -// /dataset/ownerEmail/datasetName/versionName/fileRelativePath +// DatasetFileNode represents a unique file in a versioned resource (dataset or model). Review Comment: The name is confusing, `DatasetFileNode` is used for both `dataset` and `model` but its name has dataset in it. Change it to `LakeFSFileNode` ########## file-service/src/main/scala/org/apache/texera/service/type/dataset/DatasetFileNode.scala: ########## @@ -24,9 +24,11 @@ import org.apache.texera.amber.core.storage.ResourceType import scala.collection.mutable -// DatasetFileNode represents a unique file in dataset, its full path is in the format of: -// /dataset/ownerEmail/datasetName/versionName/fileRelativePath +// DatasetFileNode represents a unique file in a versioned resource (dataset or model). Review Comment: The name is confusing, `DatasetFileNode` is used for both `dataset` and `model` but its name has dataset in it. Change it to `LakeFSFileNode` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
