tanishqgandhi1908 commented on code in PR #7762: URL: https://github.com/apache/texera/pull/7762#discussion_r3832938182
########## file-service/src/main/scala/org/apache/texera/service/type/dataset/DatasetFileNode.scala: ########## @@ -24,9 +24,11 @@ import org.apache.texera.amber.core.storage.ResourceType import scala.collection.mutable -// DatasetFileNode represents a unique file in dataset, its full path is in the format of: -// /dataset/ownerEmail/datasetName/versionName/fileRelativePath +// DatasetFileNode represents a unique file in a versioned resource (dataset or model). Review Comment: Done — `DatasetFileNode` → `LakeFSFileNode`, along with `DatasetFileNodeSerializer` and both specs, and moved out of `type/dataset/` into `type/` since the package was already `service.type`. This was queued for the model PR, but you're right that this is the PR that makes the class resource-neutral, so it belongs here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
