eugenegujing commented on code in PR #7944:
URL: https://github.com/apache/texera/pull/7944#discussion_r3877428393
##########
frontend/src/app/common/service/computing-unit/computing-unit-status/computing-unit-status.service.ts:
##########
@@ -229,6 +229,10 @@ export class ComputingUnitStatusService implements
OnDestroy {
return ComputingUnitState.Running;
case "Pending":
return ComputingUnitState.Pending;
+ case "Failed":
+ return ComputingUnitState.Failed;
+ case "Unknown":
+ return ComputingUnitState.Unknown;
Review Comment:
Added Terminating to ComputingUnitState, mapped it explicitly, made the run
button show a disabled Shutting Down state and preserved the Pending fallback
for genuinely unrecognized statuses in a4f24d0ce6ca4176baefc6bd74129279a04bb72a
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/resource/AdminComputingUnitResource.scala:
##########
@@ -99,7 +99,7 @@ class AdminComputingUnitResource {
isOwner = unit.getUid.equals(user.getUid),
Review Comment:
Separated status-reason visibility from ownership so the admin list exposes
statusReason for every row without incorrectly marking other users' units as
owned, and ordinary shared users still receive no reason in
a4f24d0ce6ca4176baefc6bd74129279a04bb72a
##########
computing-unit-managing-service/src/main/scala/org/apache/texera/service/util/ComputingUnitHelpers.scala:
##########
@@ -55,42 +62,140 @@ object ComputingUnitHelpers {
}
def getComputingUnitStatus(unit: WorkflowComputingUnit): ComputingUnitState =
Review Comment:
Removed in a4f24d0ce6ca4176baefc6bd74129279a04bb72a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
