eugenegujing commented on code in PR #7944:
URL: https://github.com/apache/texera/pull/7944#discussion_r3877431424
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.ts:
##########
@@ -580,6 +580,26 @@ export class ComputingUnitSelectionComponent implements
OnInit {
return getComputingUnitStatusTooltip(unit);
}
+ /**
+ * Row tooltip for a unit that cannot be selected. The status tooltip may
already
+ * end with a period (e.g. an owner-facing statusReason), so trim it before
+ * appending the sentence to avoid a doubled dot.
+ */
+ getCannotSelectTooltip(unit: DashboardWorkflowComputingUnit): string {
+ return `${this.getUnitStatusTooltip(unit).replace(/\.$/, "")}. Cannot
select.`;
+ }
+
+ /**
+ * The tooltip for a dropdown row: the status/reason, plus the cannot-select
+ * sentence when the unit is not selectable. The badge and name inside the
row
+ * deliberately carry no tooltip of their own, so hovering the row body
shows a
+ * single bubble. (The action icons keep their own tooltips, which stack on
top
+ * of the row's while hovered — same as main's behavior on non-selectable
rows.)
+ */
+ getRowTooltip(unit: DashboardWorkflowComputingUnit): string {
+ return this.cannotSelectUnit(unit) ? this.getCannotSelectTooltip(unit) :
this.getUnitStatusTooltip(unit);
+ }
Review Comment:
Fixed in a4f24d0ce6ca4176baefc6bd74129279a04bb72a
##########
frontend/src/app/workspace/component/power-button/computing-unit-selection.component.scss:
##########
Review Comment:
Removed in a4f24d0ce6ca4176baefc6bd74129279a04bb72a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
