zyratlo commented on PR #8032: URL: https://github.com/apache/texera/pull/8032#issuecomment-5456781818
Flagging that tests are a large share of this PR: 728 of the 1380 added lines, about 53%, or a 1.40:1 ratio against production code. Most of that came from a coverage pass after Codecov reported 42 missing lines on the first push. The biggest single file is `JupyterKubernetesClientSpec` at 188 lines, and much of it is Mockito scaffolding rather than assertions. fabric8's fluent API returns type variables, so `RETURNS_DEEP_STUBS` cannot be used and every step of each chain is stubbed by hand. That mirrors what `KubernetesClientSpec` in `computing-unit-managing-service` already does. The payoff is that the pod spec is now asserted field by field, including the hostname and subdomain pair that makes the pod FQDN resolve, which nothing covered before. The six new files under `util/` are at 100% line coverage with no missed lines. The branch partials that remain are `scala-logging` macro expansions, which would need the suite run at two log levels to cover, so I left them rather than contort the tests. Worth noting the production side is smaller than the 520 figure suggests: `NotebookMigrationResource.scala` shows 49 added against 49 deleted because `JupyterEndpoints` and the reachability probe moved out into `util/`, so the genuinely new logic is the 451 lines across the six new files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
