yangzhang75 commented on code in PR #8125:
URL: https://github.com/apache/texera/pull/8125#discussion_r3890626878
##########
amber/src/main/scala/org/apache/texera/web/resource/dashboard/WorkflowSearchQueryBuilder.scala:
##########
@@ -54,7 +54,8 @@ object WorkflowSearchQueryBuilder extends SearchQueryBuilder {
ownerId = WORKFLOW_OF_USER.UID,
userName = USER.NAME,
projectsOfWorkflow = groupConcatDistinct(WORKFLOW_OF_PROJECT.PID),
- workflowCoverImage =
DSL.max(WORKFLOW_COVER_IMAGE.IMAGE).as("workflow_cover_image")
+ workflowCoverImage =
DSL.max(WORKFLOW_COVER_IMAGE.IMAGE).as("workflow_cover_image"),
+ workflowIsFormView = WORKFLOW.IS_FORM_VIEW.as("workflow_is_form_view")
Review Comment:
Fixed, baseWorkflowSelect now projects WORKFLOW.IS_FORM_VIEW (Record10 →
Record11), and it's added to the groupBy in both callers
(retrieveWorkflowsBySessionUser and HubResource.fetchDashboardWorkflowsByWids).
mapWorkflowEntries picks it up via record.into(WORKFLOW), so /workflow/list
reports the real flag. Added a listing test asserting an enabled workflow is
reported as isFormView = true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
