mengw15 commented on code in PR #8125:
URL: https://github.com/apache/texera/pull/8125#discussion_r3899541047
##########
sql/texera_ddl.sql:
##########
@@ -166,7 +166,10 @@ CREATE TABLE IF NOT EXISTS workflow
content TEXT NOT NULL,
creation_time TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
last_modified_time TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP,
- is_public BOOLEAN NOT NULL DEFAULT false
+ is_public BOOLEAN NOT NULL DEFAULT false,
+ -- Which view the workflow opens in by default (CANVAS or FORM); the
form's definition
+ -- lives in workflow.content (`formBinding`).
+ default_view VARCHAR NOT NULL DEFAULT 'CANVAS'
Review Comment:
Any reason for VARCHAR over a PG enum? The DDL already has six `CREATE TYPE
... AS ENUM` precedents (lines 97-102), including two-value ones, and an enum
both rejects rogue values at the DB level (the app-side check only guards this
one endpoint) and gives jOOQ a typed `DefaultViewEnum` instead of string
literals. Not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
