Yicong-Huang commented on code in PR #7664:
URL: https://github.com/apache/texera/pull/7664#discussion_r3920324469
##########
common/config/src/main/resources/user-system.conf:
##########
@@ -36,6 +36,30 @@ user-sys {
}
}
+ orcid {
+ clientId = ""
+ clientId = ${?USER_SYS_ORCID_CLIENT_ID}
+
+ clientSecret = ""
+ clientSecret = ${?USER_SYS_ORCID_CLIENT_SECRET}
+
+ # The registry host, used for the authorize and token endpoints.
Review Comment:
The value carries a scheme, and the scheme is load-bearing. `getConfig`
interpolates it straight into `authorizeUrl` (`OrcidAuthResource.scala:152`),
and the login page assigns that to `window.location.href`
(`texera-login.component.ts:377`). Calling it a host invites
`USER_SYS_ORCID_BASE_URL=sandbox.orcid.org`. That resolves as a relative URL
against the app's own origin — the failure the spec pins for a blank value
(`OrcidAuthResourceSpec.scala:200-202`), except a non-blank one sails past
`missingSettings`.
```suggestion
# The registry base URL, used for the authorize and token endpoints.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
