Copilot commented on code in PR #8523:
URL: https://github.com/apache/texera/pull/8523#discussion_r3996934058
##########
.github/workflows/backport-approval-check.yml:
##########
@@ -58,7 +58,12 @@ permissions:
concurrency:
group: backport-approvals-${{ github.event.pull_request.number || github.ref
}}
- cancel-in-progress: true
+ # Queue, never cancel: this is a required status check, and GitHub takes the
LATEST
+ # check run with this name. Two events close together (a push right after a
label or
+ # review request) made the newer run cancel the older one, whose "cancelled"
state then
+ # landed after the newer run's success and blocked the merge as a failed
required
+ # check. The job runs in seconds, so queuing costs nothing.
Review Comment:
`cancel-in-progress: false` only preserves a run that is already running;
GitHub Actions still allows at most one pending run per concurrency group and
cancels/replaces an older pending run when another event arrives. Therefore
this is not a FIFO queue and it does not make every run complete as the new
comment (and PR description) claims. If the intended guarantee is only to stop
cancelling in-progress checks, please document that narrower behavior;
guaranteeing every event would require removing this shared concurrency group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
