mengw15 commented on code in PR #8523:
URL: https://github.com/apache/texera/pull/8523#discussion_r3997006261
##########
.github/workflows/backport-approval-check.yml:
##########
@@ -58,7 +58,12 @@ permissions:
concurrency:
group: backport-approvals-${{ github.event.pull_request.number || github.ref
}}
- cancel-in-progress: true
+ # Queue, never cancel: this is a required status check, and GitHub takes the
LATEST
+ # check run with this name. Two events close together (a push right after a
label or
+ # review request) made the newer run cancel the older one, whose "cancelled"
state then
+ # landed after the newer run's success and blocked the merge as a failed
required
+ # check. The job runs in seconds, so queuing costs nothing.
Review Comment:
Right — GitHub keeps at most one running and one pending run per group and
replaces the pending one, so "every run completes / FIFO" overstated it.
428dfb4ff narrows the comment and the description to the guarantee that
actually holds here: the in-progress run is never cancelled, and a replaced
pending run is cancelled before its successor even starts, so the latest check
run on the commit always ends as a real verdict — the
cancelled-state-lands-last failure mode is what is gone. A skipped intermediate
evaluation loses nothing: the job reads the live labels and reviews at run
time, not the event payload.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
