yangzhang75 opened a new pull request, #8539:
URL: https://github.com/apache/texera/pull/8539
### What changes were proposed in this PR?
`export-execution-result-enabled` is a deployment switch (default `false` in
`gui.conf`; the k8s chart turns it on). The top menu already disables its
Export entry on that switch and the context menu hides its entry, but the
download button on every result cell rendered regardless. Clicking it opened
the export dialog, and every action in the dialog (export to local, save to a
dataset, save to a newly created dataset) returned early from
`WorkflowResultExportService.performExport` with no request and no message,
after which the dialog closed. On a default local deployment this looks like a
broken feature rather than a disabled one.
This PR binds the cell button's `disabled` state to the switch and explains
it in the button's title ("Result export is disabled on this deployment"), the
same way the menu entry is disabled. Nothing changes for deployments that have
the switch on.
- `result-table-frame.component.ts`: a public `exportEnabled` getter over
`GuiConfigService`.
- `result-table-frame.component.html`: `[disabled]` and `[title]` on the
download button.
The early `return` in `performExport` is left as is; with all three entry
points now honouring the switch it is a last line of defence rather than a
user-facing path.
### Any related issues, documentation, discussions?
Closes #8538 (includes a recording of the before state).
### How was this PR tested?
- Two new unit tests in `result-table-frame.component.spec.ts`: with the
switch on the button is enabled and titled "Download data"; with it off the
button is disabled and titled "Result export is disabled on this deployment".
The switch is driven through `MockGuiConfigService.setConfig`, which is what
the component receives under `commonTestProviders`.
- `ng test --include='**/result-table-frame.component.spec.ts'`: 48/48 pass.
`eslint` and `prettier --check` clean on the three files.
- Not yet exercised in a running instance; the change is a template binding
over an existing config value.
### Was this PR authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Code (Claude Fable 5.1, Anthropic). Co-authored
with Claude; the author reviewed the change before submission.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
